Skip to content

mkdir: return a proper error mesage when dir is inexistent - #13836

Merged
cakebaker merged 4 commits into
uutils:mainfrom
Devel08:fix-issue-13833
Aug 11, 2026
Merged

mkdir: return a proper error mesage when dir is inexistent#13836
cakebaker merged 4 commits into
uutils:mainfrom
Devel08:fix-issue-13833

Conversation

@Devel08

@Devel08 Devel08 commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

closes #13833

sylvestre
sylvestre reviewed Aug 9, 2026
View reviewed changes
Comment thread src/uu/mkdir/src/mkdir.rs Outdated
Err(e) => Err(USimpleError::new(
1,
format!(
"cannot create directory '{}': {}",

@sylvestre sylvestre Aug 9, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs to use translate!

@Devel08 Devel08 Aug 9, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alr

@codspeed

codspeed Bot commented Aug 9, 2026 •
edited
Loading

Copy link
Copy Markdown

Merging this PR will improve performance by 3.74%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 2 improved benchmarks
✅ 345 untouched benchmarks
⏩ 46 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
⚡ Simulation du_max_depth_balanced_tree[(6, 4, 10)] 64.7 ms 62.3 ms +3.88%
⚡ Simulation du_summarize_balanced_tree[(5, 4, 10)] 16.6 ms 16 ms +3.61%

Tip

Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.

Comparing Devel08:fix-issue-13833 (243d869) with main (e8d14b4)

Open in CodSpeed

Footnotes

  1. 46 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@github-actions

github-actions Bot commented Aug 9, 2026 •
edited
Loading

Copy link
Copy Markdown

Binary size comparison:

Individual binary size comparison VS main (threshold: >=5% AND >=4 KB).

Total size of compared binaries: 148.95 MB (+332 KB, +0.22%)

Significant per-binary changes:
  install     1.24 MB ->    1.32 MB  (+80 KB, +6.29%)
  mkdir       1.09 MB ->    1.17 MB  (+80 KB, +7.14%)
  mkfifo      1.09 MB ->    1.16 MB  (+76 KB, +6.83%)
  mknod       1.09 MB ->    1.17 MB  (+76 KB, +6.79%)

sylvestre
sylvestre approved these changes Aug 9, 2026
View reviewed changes

@sylvestre sylvestre left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Devel08

Devel08 commented Aug 9, 2026

Copy link
Copy Markdown
Contributor Author

@sylvestre cspell isn't happy with "errormsg" though, should I try changing it to just "error"?

@github-actions

github-actions Bot commented Aug 11, 2026 •
edited
Loading

Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/cut/bounded-memory (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/pr/bounded-memory (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/tail/tail-n0f (passes in this run but fails in the 'main' branch)
Note: The gnu test tests/dd/no-allocate is now being skipped but was previously passing.
Congrats! The gnu test tests/cut/cut-huge-range is now passing!

@Devel08

Devel08 commented Aug 11, 2026

Copy link
Copy Markdown
Contributor Author

@cakebaker what do you think

@cakebaker
cakebaker merged commit 822aa83 into uutils:main Aug 11, 2026
162 of 167 checks passed
@cakebaker

cakebaker commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Thanks!

Devel08 added a commit to Devel08/coreutils that referenced this pull request Sep 28, 2026
@Devel08
mkdir: return a proper error mesage when dir is inexistent (uutils#13836
98c5831 
)

* mkdir: return a proper error mesage when dir is inexistent

* mkdir: run test only on unix

* add french and english localization

* error instead of errormsg in locales
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sylvestre sylvestre sylvestre approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

minorbug(mv): using -m leads to vague error messages

3 participants

@Devel08 @cakebaker @sylvestre